Add Axion Lighting integration #125039
Add Axion Lighting integration #125039
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
There was a problem hiding this comment.
Device specific code should be stored in a separate library hosted on pypi, check https://developers.home-assistant.io/docs/development_checklist for mroe info
…device_infoto add device
…_validate_and_authenticate function
… of coordinator to __init__.py
|
Also, if you think you did the right thing in the comment, feel free to resolve it. If you are unsure or if it was a question, or you have a question back, please leave it open This one didn't got an answer #125039 (comment) |
…ion can't be established, or in case of invalid authentication. Also, switch the value of selector to snake_case
There was a problem hiding this comment.
Let me run an idea by you, please don't rush into implementing it because I am not sure if it would make this simpler.
What if we create a subclass for every light type? So we now have the AxionDMXLight, and then you could have the AxionDMXRGBLight which contains only the RGB logic for turning on and off (we can have the shared logic of the turning off and on in the base class, but the specifics in the sub class).
But this idea is with the assumption that you can't do RGB with a RGBW or RGBWW light.
I think this would separate the logic a lot more and saves us from doing a lot of light type checking. What do you think? (and again, please don't rush into implementing, you're the expert on these lights as you've been developing this, so I could be overseeing something)
|
Hi joostlek! I've been thinking about this comment that you left, and there are few flaws with it.
You can do RGB with an RGBW or RGBWW light. Since each channel is controllable you could ignore the white on the RGBW and just do RGB if you wanted. I see no gain in breaking each light into a sub-class, this will increase the complexity in terms of the number of classes (of course on the other hand it will reduce the complexity within each class). Also, since I tested this code on real hardware, and it works just as expected I think we're okay to leave it as-is. |
|
Hi @joostlek, just wanted to check if there’s anything else needed from my side to help move this PR forward. Looking forward to your feedback. Thanks! |
|
I did see your mail yesterday, it ended up in the spam. But last week was beta week so we were busy, I'll try to take a look at it again soon |
|
Hi @joostlek, just wanted to follow up and see if there’s any chance you’ll be able to review the PR soon? I understand things can get busy, but it would be great to get some movement on this PR. Is there anything I can do to help move things along? Thanks! |
|
Hello @joostlek and @autinerd! Could we get some movement on this PR? You can pass it down to someone else on your team, if you guys are busy? As @ChrisAllenIsAwesome mentioned, we have some customers that are really excited about getting the Axion Lighting into the Home Assistant project, so that they can use the best from both worlds. Thanks in advanced! |
|
Sorry to be a pain on this, I have another person asking me about this integration. I have downloaded it and manually tried it with my system and it seems to be working properly, is there a bug or some other change needed before it can be published? |
Proposed change
This PR introduces a new integration for controlling Axion Lights via the Home Assistant UI. The integration allows users to connect their Axion DMX controllers with Home Assistant, offering support for various light types, including White, Tunable White, RGB, RGBW, and RGBWW. It provides a seamless way to manage lighting through Home Assistant, enhancing the automation capabilities for users with Axion Lighting systems.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: